codecov-commenter
commented
1 year ago Codecov Report
Patch coverage: 75.00% and project coverage change: +0.11% :tada:
Comparison is base (
b7a323d) 82.12% compared to head (51368c0) 82.24%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #315 +/- ## ========================================== + Coverage 82.12% 82.24% +0.11% ========================================== Files 20 20 Lines 8679 8660 -19 ========================================== - Hits 7128 7122 -6 + Misses 1551 1538 -13 ``` | [Files Changed](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/v5/mqtt5\_utils.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3Y1L21xdHQ1X3V0aWxzLmM=) | `80.09% <72.41%> (-2.69%)` | :arrow_down: | | [source/v5/mqtt5\_options\_storage.c](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3Y1L21xdHQ1X29wdGlvbnNfc3RvcmFnZS5j) | `90.59% <100.00%> (+0.09%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-mqtt/pull/315/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
$share/<share-name>to the iot core validation utility functions. Adds testing for the additional functionality.Leaves the validation utility functions intact. We have determined these were not necessary in MQTT5 (and unnecessary client-side validation should always be avoided for future-compatibility reasons) as IoT Core now returns sensible reason codes that help us diagnose these issues (when using MQTT5; MQTT311 continues to be impacted due to the limitations of the spec). We may revisit and use this functionality as an opt-in setting on the 311 client to help prevent/diagnose particular problems.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.