search

awslabs / aws-c-mqtt

C99 implementation of the MQTT 3.1.1 specification.
Apache License 2.0
93 stars 29 forks source link

Fix mqtt3 suback returned qos behavior #340

Closed xiazhvera closed 9 months ago

xiazhvera commented 10 months ago

Issue #, if available:

Description of changes: The Mqtt3 client would now return AWS_MQTT_QOS_FAILURE as qos value if the subscription failed with error code. While Mqtt3 client would directly return the request qos value. This change would introduce behavior changes in CPP, Python and NodeJS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (17ee24a) 82.41% compared to head (0ef6d3f) 82.40%.

Files Patch % Lines
source/client.c 60.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #340 +/- ## ========================================== - Coverage 82.41% 82.40% -0.02% ========================================== Files 20 20 Lines 8779 8785 +6 ========================================== + Hits 7235 7239 +4 - Misses 1544 1546 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xiazhvera commented 9 months ago

Hold off because it introduce a behavior change.