Adapt to XML API changes

[graebm]

Issue The XML API was hard to use right, leading to bugs like this: https://github.com/awslabs/aws-c-s3/issues/328

Description of changes:

• Adapt to API changes from: https://github.com/awslabs/aws-c-common/pull/1043
• Break up node traversal functions, to ensure we're processing the correct XML elements.
  • Previously, the same callback would be used for all XML elements. This could cause error if an element with the same name occurred at different parts of the document tree.
• Improved error checking
  • Previously, many calls to aws_xml_node_as_body() weren't being checked for error.
• Replace ~aws_xml_get_top_level_tag()~ and ~aws_xml_get_top_level_tag_with_root_name()~ with aws_xml_get_body_at_path()
  • ~aws_xml_get_top_level_tag()~ didn't check the name of the root node
  • ~aws_xml_get_top_level_tag_with_root_name()~ was clunky to use (IMHO)
  • so replace with an API that can retrieve an element at any depth (not just 2), checking names the whole way, and with a nicer API (IMHO).
  • new function gives aws_byte_cursor instead of aws_string, the user was usually just deleting it afterwards, which made their error-handling more complicated.
• Trivial stuff:
  • Remove unused functions ~aws_s3_list_objects_operation_new()~ and ~aws_s3_initiate_list_parts()~
  • aws_replace_quote_entities() returns aws_byte_buf by value, instead of as out-param
  • Some functions take aws_byte_cursor by value, instead taking aws_string * or aws_byte_buf * or aws_byte_cursor * by pointer

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

Merging #332 (c08cd14) into main (bc9c8b2) will increase coverage by 0.48%. The diff coverage is 93.64%.

Additional details and impacted files

[](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #332 +/- ## ========================================== + Coverage 88.93% 89.42% +0.48% ========================================== Files 17 17 Lines 4972 4888 -84 ========================================== - Hits 4422 4371 -51 + Misses 550 517 -33 ``` | [Impacted Files](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzLmM=) | `96.15% <ø> (ø)` | | | [source/s3\_paginator.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3BhZ2luYXRvci5j) | `88.23% <80.76%> (-2.50%)` | :arrow_down: | | [source/s3\_list\_parts.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2xpc3RfcGFydHMuYw==) | `92.70% <88.23%> (+17.89%)` | :arrow_up: | | [source/s3\_auto\_ranged\_put.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX3B1dC5j) | `92.19% <88.88%> (-0.25%)` | :arrow_down: | | [source/s3\_auto\_ranged\_get.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX2dldC5j) | `98.55% <100.00%> (-0.01%)` | :arrow_down: | | [source/s3\_copy\_object.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2NvcHlfb2JqZWN0LmM=) | `81.14% <100.00%> (-0.13%)` | :arrow_down: | | [source/s3\_list\_objects.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2xpc3Rfb2JqZWN0cy5j) | `92.38% <100.00%> (+12.07%)` | :arrow_up: | | [source/s3\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX21ldGFfcmVxdWVzdC5j) | `92.73% <100.00%> (-0.61%)` | :arrow_down: | | [source/s3\_util.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3V0aWwuYw==) | `98.66% <100.00%> (-0.07%)` | :arrow_down: |