awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
94 stars 38 forks source link

Progress callbacks fire for all meta-request types #344

Closed graebm closed 1 year ago

graebm commented 1 year ago

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Merging #344 (6ea1c3f) into main (75788fb) will decrease coverage by 0.02%. The diff coverage is 97.41%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #344 +/- ## ========================================== - Coverage 89.52% 89.51% -0.02% ========================================== Files 17 17 Lines 4897 4929 +32 ========================================== + Hits 4384 4412 +28 - Misses 513 517 +4 ``` | [Files Changed](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3\_auto\_ranged\_get.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX2dldC5j) | `97.88% <91.66%> (-0.67%)` | :arrow_down: | | [source/s3\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX21ldGFfcmVxdWVzdC5j) | `92.60% <96.66%> (-0.74%)` | :arrow_down: | | [source/s3\_auto\_ranged\_put.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX3B1dC5j) | `92.25% <100.00%> (+0.06%)` | :arrow_up: | | [source/s3\_client.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2NsaWVudC5j) | `87.98% <100.00%> (-0.05%)` | :arrow_down: | | [source/s3\_copy\_object.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2NvcHlfb2JqZWN0LmM=) | `82.83% <100.00%> (+1.69%)` | :arrow_up: | | [source/s3\_default\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2RlZmF1bHRfbWV0YV9yZXF1ZXN0LmM=) | `94.59% <100.00%> (+0.34%)` | :arrow_up: | | [source/s3\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3JlcXVlc3QuYw==) | `95.23% <100.00%> (+0.04%)` | :arrow_up: | | [source/s3\_util.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3V0aWwuYw==) | `98.66% <100.00%> (ø)` | |