awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
102 stars 41 forks source link

Explicit Private for target_link_libraries #345

Closed waahm7 closed 1 year ago

waahm7 commented 1 year ago

Description of changes:

Source: https://cmake.org/pipermail/cmake/2016-May/063400.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Merging #345 (da981fb) into main (a691a2f) will increase coverage by 0.07%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/345/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/345?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #345 +/- ## ========================================== + Coverage 89.42% 89.49% +0.07% ========================================== Files 17 17 Lines 4888 4895 +7 ========================================== + Hits 4371 4381 +10 + Misses 517 514 -3 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/345/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)