search

awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
101 stars 41 forks source link

Parallel read #352

Closed TingDaoK closed 1 year ago

TingDaoK commented 1 year ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Merging #352 (f75c45a) into main (00a1129) will decrease coverage by 0.48%. The diff coverage is 78.47%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #352 +/- ## ========================================== - Coverage 89.56% 89.08% -0.48% ========================================== Files 17 18 +1 Lines 4933 5046 +113 ========================================== + Hits 4418 4495 +77 - Misses 515 551 +36 ``` | [Files Changed](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzLmM=) | `96.15% <ø> (ø)` | | | [source/s3\_request\_messages.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3JlcXVlc3RfbWVzc2FnZXMuYw==) | `73.75% <ø> (-1.02%)` | :arrow_down: | | [source/s3\_parallel\_read\_stream.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3BhcmFsbGVsX3JlYWRfc3RyZWFtLmM=) | `73.04% <73.04%> (ø)` | | | [source/s3\_auto\_ranged\_put.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX3B1dC5j) | `92.22% <100.00%> (-0.03%)` | :arrow_down: | | [source/s3\_default\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2RlZmF1bHRfbWV0YV9yZXF1ZXN0LmM=) | `92.56% <100.00%> (-2.03%)` | :arrow_down: | | [source/s3\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX21ldGFfcmVxdWVzdC5j) | `92.54% <100.00%> (-0.08%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/352/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)
TingDaoK commented 1 year ago

prefer to https://github.com/awslabs/aws-c-s3/pull/353