awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
94 stars 38 forks source link

instead of skipping, let's prepare the parts and mark it noop #356

Closed TingDaoK closed 11 months ago

TingDaoK commented 11 months ago

TODO:

Maybe, we can be more smarter? If the part uploaded doesn't have a checksum, we can skip reading the part? Or let user config that if they want us to read the parts uploaded.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 11 months ago

Codecov Report

Merging #356 (e87fdd4) into para-pre-rcbc (122ac29) will increase coverage by 89.59%. The diff coverage is 93.10%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/356/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## para-pre-rcbc #356 +/- ## ================================================== + Coverage 0 89.59% +89.59% ================================================== Files 0 18 +18 Lines 0 4893 +4893 ================================================== + Hits 0 4384 +4384 - Misses 0 509 +509 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3\_auto\_ranged\_put.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX3B1dC5j) | `92.54% <93.10%> (ø)` | | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/356/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)