search

awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
101 stars 41 forks source link

Fix typo in aws_cached_signing_config_new #358

Closed waahm7 closed 1 year ago

waahm7 commented 1 year ago

Issue #, if available:

357

Description of changes: Fixes a possible bad copy paste error where we check for service.len but assign signed_body_value.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 year ago

Codecov Report

Merging #358 (a87e0a4) into main (f710806) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/358/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #358 +/- ## ======================================= Coverage 89.59% 89.59% ======================================= Files 18 18 Lines 4893 4893 ======================================= Hits 4384 4384 Misses 509 509 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3\_util.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3V0aWwuYw==) | `98.67% <100.00%> (ø)` | |