search

awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
101 stars 41 forks source link

Remove Populating Empty Error Body #366

Closed waahm7 closed 12 months ago

waahm7 commented 12 months ago

Description of changes: The S3 sends an XML payload, and just sending aws_http_status_text in the payload is not helpful since the XML parser cannot parse it. Let the downstream dependencies handle how they want to model a null payload by S3.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 12 months ago

Codecov Report

Merging #366 (2131447) into main (ecaf3f7) will decrease coverage by 0.02%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/366/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #366 +/- ## ========================================== - Coverage 88.28% 88.26% -0.02% ========================================== Files 19 19 Lines 5044 5036 -8 ========================================== - Hits 4453 4445 -8 Misses 591 591 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX21ldGFfcmVxdWVzdC5j) | `92.83% <ø> (-0.08%)` | :arrow_down: |