search

awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
94 stars 38 forks source link

Cleanup CPU group array info code #369

Closed waahm7 closed 10 months ago

waahm7 commented 10 months ago

Description of changes: Remove CPU group info code block as a TODO since it is not used for now. Currently, Valgrind detects a memory leak associated with the g_numa_node_of_cpu_ptr function. This issue requires further investigation to either resolve or suppress it before reintegrating this code segment. However, future developments might lean towards eliminating the use of numactl altogether.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 10 months ago

Codecov Report

Merging #369 (73c8ec5) into main (89791b1) will increase coverage by 0.01%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/369/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #369 +/- ## ========================================== + Coverage 88.45% 88.47% +0.01% ========================================== Files 19 19 Lines 5129 5120 -9 ========================================== - Hits 4537 4530 -7 + Misses 592 590 -2 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3\_platform\_info.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3BsYXRmb3JtX2luZm8uYw==) | `45.33% <ø> (-3.10%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/369/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)