Report S3 operation name of specific request that failed.

[graebm]

Issue: It was difficult to map errors from aws-c-s3 into errors in other AWS SDKs without knowing exactly which HTTP request failed.

For example, if AWS_S3_META_REQUEST_TYPE_PUT_OBJECT fails, they need to know whether it was a "PutObject", "CreateMultipartUpload", "UploadPart", or "CompleteMultipartUpload" HTTP request that failed.

Description of changes:

• Report the S3 operation name of the specific HTTP request that failed (e.g. "CreateMultipartUpload").
• Likewise, report that operation name in metrics.
• For AWS_S3_META_REQUEST_TYPE_DEFAULT, where aws-c-s3 isn't sure what operation is being performed, allow the user to pass in the operation name.
• Internally, pass request_type and operation_name around directly. Instead of querying them via vtable gymnastics, which I found confusing and error-prone.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

Merging #377 (77e2a5c) into main (7192ab5) will increase coverage by 0.08%. The diff coverage is 96.66%.

Additional details and impacted files

[](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #377 +/- ## ========================================== + Coverage 88.55% 88.64% +0.08% ========================================== Files 20 20 Lines 5348 5380 +32 ========================================== + Hits 4736 4769 +33 + Misses 612 611 -1 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3\_auto\_ranged\_get.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX2dldC5j) | `98.26% <100.00%> (+0.64%)` | :arrow_up: | | [source/s3\_auto\_ranged\_put.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX3B1dC5j) | `92.67% <ø> (-0.03%)` | :arrow_down: | | [source/s3\_copy\_object.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2NvcHlfb2JqZWN0LmM=) | `83.05% <ø> (-0.17%)` | :arrow_down: | | [source/s3\_default\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2RlZmF1bHRfbWV0YV9yZXF1ZXN0LmM=) | `94.96% <100.00%> (+0.33%)` | :arrow_up: | | [source/s3\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX21ldGFfcmVxdWVzdC5j) | `92.94% <100.00%> (+0.12%)` | :arrow_up: | | [source/s3\_util.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3V0aWwuYw==) | `98.79% <100.00%> (+0.11%)` | :arrow_up: | | [source/s3\_client.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2NsaWVudC5j) | `88.91% <50.00%> (ø)` | | | [source/s3\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3JlcXVlc3QuYw==) | `95.06% <94.11%> (-0.20%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/377/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)