awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.

Apache License 2.0

94 stars 38 forks source link

Build broken since #360 #378

Closed snickl closed 9 months ago

snickl commented 9 months ago

Describe the bug

360 introduced AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT and others, which aren't defined

Expected Behavior

Package compiles

Current Behavior

Does not compile

Reproduction Steps

Compile package

Possible Solution

No response

Additional Information/Context

No response

aws-c-s3 version used

0.3.23..0.4.0

Compiler and version used

gcc 12

Operating System and version

debian 11 / buildroot 2023.08

jmklix commented 9 months ago

Can you provide more details about this? What errors are you seeing when you try to build? and what steps are you using to build?

waahm7 commented 9 months ago

You need to ensure that the dependencies (aws-c-* packages like aws-c-http, aws-c-common, etc.) are also updated to the latest version.

snickl commented 9 months ago

I'm packaging aws-iot-device-sdk-cpp-v2 and aws-iot-fleetwise-edge for buildroot, using the latest versions of each package as I've moved down the dependency chain. It seems the cmake package dependencies are all satisfied, and I haven't seen a missing header error. What package/header is supposed to provide AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT et.al.?

DmitriyMusatkin commented 9 months ago

AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT should be defined in the latest release of aws-c-http

snickl commented 9 months ago

AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT should be defined in the latest release of aws-c-http

You're right. So there's at least one package I must have missed when switching on release notifications...

Thanks!