fix two bugs from metrics and cancel

[TingDaoK]

Issue #, if available:

• The downstream CI caught the bugs.
• One is when we have pending streaming requests in the list, we finishing the meta request by just release the refcount on those requests. But we wait the eventloop to delivery the metrics while they delivery the body streaming for those requests. So, those requests will leak the metrics memory
• The second one is that when the cancel for the http stream was invoked after the stream has already completed, or completing. The error code on complete will not be the error code we asked for canceling. So, we cannot rely on the error code to check for the node has been removed or not.

Description of changes:

• Finish up the metrics from the meta request finish function as well. Double-checked that nothing else will pop from the priority list to deliver the body
• Rely on the synced_data.http_stream to track the linked-list node should be removed or not

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov-commenter]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (f1ba15e) 88.74% compared to head (33e40a3) 88.97%.

:exclamation: Current head 33e40a3 differs from pull request most recent head e10dbd2. Consider uploading reports for the commit e10dbd2 to get more accurate results

Additional details and impacted files

[](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #399 +/- ## ========================================== + Coverage 88.74% 88.97% +0.23% ========================================== Files 21 21 Lines 6024 6043 +19 ========================================== + Hits 5346 5377 +31 + Misses 678 666 -12 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3\_auto\_ranged\_put.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX3B1dC5j) | `92.58% <100.00%> (ø)` | | | [source/s3\_util.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX3V0aWwuYw==) | `99.63% <100.00%> (+<0.01%)` | :arrow_up: | | [source/s3\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX21ldGFfcmVxdWVzdC5j) | `92.08% <88.63%> (+1.46%)` | :arrow_up: |