search

awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
93 stars 37 forks source link

Auto - Update S3 Ruleset & Partition #408

Closed waahm7 closed 5 months ago

waahm7 commented 5 months ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.35%. Comparing base (59569e3) to head (5c8be46).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/408/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #408 +/- ## ========================================== - Coverage 89.37% 89.35% -0.02% ========================================== Files 20 20 Lines 5854 5854 ========================================== - Hits 5232 5231 -1 - Misses 622 623 +1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)
waahm7 commented 5 months ago

can we not merge the workaround with this PR? I would like we can revert those workaround once the github action releases the fix next Friday.

I am not going to merge the workaround with this PR. I am just testing if the CI works.