search

awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
93 stars 37 forks source link

WIP | Connection pool destroy issue 2 #416

Closed waahm7 closed 5 months ago

waahm7 commented 5 months ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.42%. Comparing base (74c2df6) to head (5279a79).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/416/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## connection-pool-destroy-issue #416 +/- ## ================================================================= - Coverage 89.44% 89.42% -0.02% ================================================================= Files 20 20 Lines 5902 5894 -8 ================================================================= - Hits 5279 5271 -8 Misses 623 623 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/416?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3\_client.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2NsaWVudC5j) | `88.40% <100.00%> (-0.03%)` | :arrow_down: | | [source/s3\_endpoint.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2VuZHBvaW50LmM=) | `91.55% <100.00%> (-0.32%)` | :arrow_down: |