search

awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
93 stars 37 forks source link

Small buffer #422

Closed DmitriyMusatkin closed 4 months ago

DmitriyMusatkin commented 5 months ago

Issue #, if available:

Description of changes: fix large s3 errors not being processed correctly and returning weird buffer too small error instead.

fixes issues like https://github.com/aws/aws-sdk-cpp/issues/2892

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.40%. Comparing base (3085fd7) to head (7a4f12c).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/422/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #422 +/- ## ======================================= Coverage 89.40% 89.40% ======================================= Files 20 20 Lines 5868 5872 +4 ======================================= + Hits 5246 5250 +4 Misses 622 622 ``` | [Files](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/422?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) | Coverage Δ | | |---|---|---| | [source/s3\_meta\_request.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/422?src=pr&el=tree&filepath=source%2Fs3_meta_request.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX21ldGFfcmVxdWVzdC5j) | `92.25% <100.00%> (+0.01%)` | :arrow_up: | | [source/s3\_auto\_ranged\_get.c](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/422?src=pr&el=tree&filepath=source%2Fs3_auto_ranged_get.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs#diff-c291cmNlL3MzX2F1dG9fcmFuZ2VkX2dldC5j) | `97.77% <80.00%> (+0.01%)` | :arrow_up: |