search

awslabs / aws-c-s3

C99 library implementation for communicating with the S3 service, designed for maximizing throughput on high bandwidth EC2 instances.
Apache License 2.0
93 stars 37 forks source link

Add 'Content-Length: 0' header on multipart upload creation #426

Closed thundergolfer closed 3 months ago

thundergolfer commented 4 months ago

Issue #: https://github.com/awslabs/mountpoint-s3/issues/853

Description of changes:

As is done by the other methods (using aws_s3_message_util_assign_body) set the 'Content-Length' header on multi-part upload creation. Google Cloud Storage requires this header to be present, and AWS will accept it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

thundergolfer commented 3 months ago

@waahm7 would you be able to look at this? 🙂

waahm7 commented 3 months ago

@thundergolfer Thank you for creating the PR. Sure, I will take a look and let you know as soon as I have any updates.

thundergolfer commented 3 months ago

@waahm7 friendly bump on this. just for planning on our side, what's the rough estimate on how soon this can be merged? 🙂

waahm7 commented 3 months ago

@thundergolfer Sorry, I have been busy with other stuff and haven't had the chance to look into this yet. It's on the list of things that I am currently looking into. If Content-Length header is the only thing missing, we should be able to get it merged by the end of the week in the best case or end of next week.

thundergolfer commented 3 months ago

Thanks for the update 🙏. I don't mean to rush at all.

waahm7 commented 3 months ago

Thank you for your contribution. It LGTM but the CI is failing. I have created a duplicate PR #428 to fix the CI.

thundergolfer commented 3 months ago

Thanks!

waahm7 commented 3 months ago

@thundergolfer This fix is released in https://github.com/awslabs/aws-c-s3/releases/tag/v0.5.8