Make options more const

DmitriyMusatkin commented 1 month ago

Issue #, if available:

Description of changes: make everything passed in by pointer in options const as we always copy the underlying data. everything that is ref counted is kept as is, since refcounted functions dont play with const ptrs nicely

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.62%. Comparing base (813c418) to head (86c4d9a).

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/445/graphs/tree.svg?width=650&height=150&src=pr&token=J4KP54FVLF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs)](https://app.codecov.io/gh/awslabs/aws-c-s3/pull/445?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=awslabs) ```diff @@ Coverage Diff @@ ## main #445 +/- ## ======================================= Coverage 89.62% 89.62% ======================================= Files 20 20 Lines 6092 6092 ======================================= Hits 5460 5460 Misses 632 632 ```

DmitriyMusatkin commented 1 month ago

I'd advise checking this branch from aws-crt-cpp, and making sure it all works nicely, before merging

crt cpp actually does not wrap s3 now. i checked cpp sdk and its fine with it. i will check other bindinds

awslabs / aws-c-s3

Make options more const #445

Codecov Report