search

awslabs / aws-codedeploy-plugin

Jenkins plugin for AWS CodeDeploy
Apache License 2.0
153 stars 132 forks source link

Allow Symlinks in Subdirectory #56

Open alexanderrtaylor opened 8 years ago

alexanderrtaylor commented 8 years ago

Inside of this: private FilePath getSourceDirectory(FilePath basePath) throws IOException, InterruptedException { String subdirectory = StringUtils.trimToEmpty(this.subdirectory); if (!subdirectory.isEmpty() && !subdirectory.startsWith("/")) { subdirectory = "/" + subdirectory; } FilePath sourcePath = basePath.withSuffix(subdirectory).absolutize(); if (!sourcePath.isDirectory() || !isSubDirectory(basePath, sourcePath)) { throw new IllegalArgumentException("Provided path (resolved as '" + sourcePath +"') is not a subdirectory of the workspace (resolved as '" + basePath + "')"); } return sourcePath; }

Can we get another clause that will allow for symlinks to also not throw the illegal argument?

annamataws commented 6 years ago

Hi,

Thank you for your feature request. I have added an item in our backlog to be Triaged.