awslabs / aws-config-engine-for-compliance-as-code

Manage AWS Config Rules at scale in AWS multi-account and/or multi-region environment; with fully configurable deployment (RuleSets) and analytics.
Apache License 2.0
276 stars 96 forks source link

CloudFormation: Use Sub instead of Join[Ref, GetAttr] #57

Closed jack1902 closed 3 years ago

jack1902 commented 4 years ago

Background

Description

The CloudFormation Templates should use Fn::Sub in place of Fn::Join with Fn::Ref and Fn::GetAttr as it makes for easier reading.

I believe making this change will make reading the CloudFormation Templates easier.

Documentation

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-sub.html

Desired Change

Use Fn::Sub as it is cleaner