Closed santosh-at-github closed 5 years ago
Can you write the scenarios as "The Elasticache Redis cluster has automatic backup enabled" not "All ...". It is because you report on individual resources. You would write "One or more..." if you were reporting on AWS::::Account.
Scenario 1 needs to report COMPLIANT
You need another Scenario if there is no Cluster, reporting NOT_APPLICABLE
Gherkin has been updated as per above suggestion.
Updated:
Idea: Since you mention 0, then it is probably worth to have an optional parameter that allow to configure a target number of days, with 90 days by default. What do you think?
Thank you for making those changes.
Using parameter for the snapshot retention period is a good idea, however it's default value of 90 days will be too long I think. 15 days default snapshot retention period would be fine?
Good to go!