awslabs / aws-config-rules

[Node, Python, Java] Repository of sample Custom Rules for AWS Config.
http://aws.amazon.com/config/
Creative Commons Zero v1.0 Universal
1.61k stars 854 forks source link

Add Config Rule to detect overly permissive NACLs #302

Open amalq1 opened 4 years ago

amalq1 commented 4 years ago

Description of changes:

This config rule will check both Network ACLs and Security Groups for overly permissive ingress rules. The specific checks that are performed against NACL and SG rules are:

I confirm these files are made available under CC0 1.0 Universal (https://creativecommons.org/publicdomain/zero/1.0/legalcode)

good-bot commented 4 years ago

Module VPC_NACL_SG_CONFIGURATION_ALIGNMENT_test VPC_NACL_SG_CONFIGURATION_ALIGNMENT/VPC_NACL_SG_CONFIGURATION_ALIGNMENT_test.py:57:8: W1503: Redundant use of assertTrue with constant value True (redundant-unittest-assert) Module VPC_NACL_SG_CONFIGURATION_ALIGNMENT VPC_NACL_SG_CONFIGURATION_ALIGNMENT/VPC_NACL_SG_CONFIGURATIONALIGNMENT.py:120:16: C0103: Variable name "ip" doesn't conform to '[a-z][a-z0-9_]{2,30}$' pattern (invalid-name) VPC_NACL_SG_CONFIGURATION_ALIGNMENT/VPC_NACL_SG_CONFIGURATION_ALIGNMENT.py:145:15: C0121: Comparison to True should be just 'expr' (singleton-comparison)


Your code has been rated at 10.00/10

good-bot commented 4 years ago

Your code has been rated at 10.00/10

good-bot commented 4 years ago

Your code has been rated at 10.00/10