awslabs / aws-config-rules

[Node, Python, Java] Repository of sample Custom Rules for AWS Config.
http://aws.amazon.com/config/
Creative Commons Zero v1.0 Universal
1.61k stars 854 forks source link

Kenzhang #309

Closed kenpkzhang closed 4 years ago

kenpkzhang commented 4 years ago

I confirm these files are made available under CC0 1.0 Universal (https://creativecommons.org/publicdomain/zero/1.0/legalcode)

Issue #, if available:

Description of changes: Adding EKS Config rule to detect if EKS Control Plane is set to publicly accessible

good-bot commented 4 years ago

Module EKS_Public_Access_test EKS_Public_Access/EKS_Public_Access_test.py:1:0: C0103: Module name "EKS_Public_Access_test" doesn't conform to '(?=.{2,128}$)([A-Z][A-Z_0-9]+A-Z0-9?)$' pattern (invalid-name) EKS_Public_Access/EKS_Public_Access_test.py:57:8: W1503: Redundant use of assertTrue with constant value True (redundant-unittest-assert) Module EKS_Public_Access EKS_Public_Access/EKS_Public_Access.py:59:68: C0326: Exactly one space required after comma evaluations.append(build_evaluation(cluster_info['name'],'NON_COMPLIANT',event)) ^ (bad-whitespace) EKS_Public_Access/EKS_Public_Access.py:59:84: C0326: Exactly one space required after comma evaluations.append(build_evaluation(cluster_info['name'],'NON_COMPLIANT',event)) ^ (bad-whitespace) EKS_Public_Access/EKS_Public_Access.py:62:68: C0326: Exactly one space required after comma evaluations.append(build_evaluation(cluster_info['name'],'COMPLIANT',event)) ^ (bad-whitespace) EKS_Public_Access/EKS_Public_Access.py:62:80: C0326: Exactly one space required after comma evaluations.append(build_evaluation(cluster_info['name'],'COMPLIANT',event)) ^ (bad-whitespace) EKS_Public_Access/EKS_Public_Access.py:1:0: C0103: Module name "EKS_Public_Access" doesn't conform to '(?=.{2,128}$)([A-Z][A-Z_0-9]+A-Z0-9?)$' pattern (invalid-name) EKS_Public_Access/EKS_Public_Access.py:58:11: C0121: Comparison to True should be just 'expr' (singleton-comparison)


Your code has been rated at 9.99/10

good-bot commented 4 years ago

***** Module EKS_Public_Access EKS_Public_Access/EKS_Public_Access.py:1:0: C0103: Module name "EKS_Public_Access" doesn't conform to '(?=.{2,128}$)([A-Z][A-Z_0-9]+A-Z0-9?)$' pattern (invalid-name) EKS_Public_Access/EKS_Public_Access.py:58:11: C0121: Comparison to True should be just 'expr' (singleton-comparison)


Your code has been rated at 10.00/10

good-bot commented 4 years ago

***** Module EKS_Public_Access EKS_Public_Access/EKS_Public_Access.py:59:68: C0326: Exactly one space required after comma evaluations.append(build_evaluation(cluster_info['name'],'NON_COMPLIANT',event)) ^ (bad-whitespace) EKS_Public_Access/EKS_Public_Access.py:59:84: C0326: Exactly one space required after comma evaluations.append(build_evaluation(cluster_info['name'],'NON_COMPLIANT',event)) ^ (bad-whitespace) EKS_Public_Access/EKS_Public_Access.py:62:68: C0326: Exactly one space required after comma evaluations.append(build_evaluation(cluster_info['name'],'COMPLIANT',event)) ^ (bad-whitespace) EKS_Public_Access/EKS_Public_Access.py:62:80: C0326: Exactly one space required after comma evaluations.append(build_evaluation(cluster_info['name'],'COMPLIANT',event)) ^ (bad-whitespace) EKS_Public_Access/EKS_Public_Access.py:1:0: C0103: Module name "EKS_Public_Access" doesn't conform to '(?=.{2,128}$)([A-Z][A-Z_0-9]+A-Z0-9?)$' pattern (invalid-name) EKS_Public_Access/EKS_Public_Access.py:58:11: C0121: Comparison to True should be just 'expr' (singleton-comparison)


Your code has been rated at 9.99/10

good-bot commented 4 years ago

***** Module EKS_Public_Access EKS_Public_Access/EKS_Public_Access.py:1:0: C0103: Module name "EKS_Public_Access" doesn't conform to '(?=.{2,128}$)([A-Z][A-Z_0-9]+A-Z0-9?)$' pattern (invalid-name) EKS_Public_Access/EKS_Public_Access.py:58:11: C0121: Comparison to True should be just 'expr' (singleton-comparison)


Your code has been rated at 10.00/10