search

awslabs / aws-config-rules

[Node, Python, Java] Repository of sample Custom Rules for AWS Config.
http://aws.amazon.com/config/
Creative Commons Zero v1.0 Universal
1.6k stars 854 forks source link

VPC_SG_OPEN_ONLY_TO_AUTHORIZED_PORTS #326

Open kynwu opened 4 years ago

kynwu commented 4 years ago

AWS managed rule: VPC_SG_OPEN_ONLY_TO_AUTHORIZED_PORTS

is using

  1. authorizedTCPPorts instead of authorizedTcpPorts
  2. authorizedUDPPorts instead of authorizedUdpPorts
kynwu commented 4 years ago

Is there any update on this?

as the naming of parameters are not consist with documentation...

jongogogo commented 4 years ago

Hey there, this code is not the AWS managed rules code, it is only a sample. If you are you looking for the managed rule code, may I ask you why?

kynwu commented 4 years ago

Hey there, this code is not the AWS managed rules code, it is only a sample. If you are you looking for the managed rule code, may I ask you why?

Hi, thanks for replying

I think it is AWS managed rules code, as it is presented on the below page? https://docs.aws.amazon.com/config/latest/developerguide/managed-rules-by-aws-config.html and from that page we can navigate to https://docs.aws.amazon.com/config/latest/developerguide/vpc-sg-open-only-to-authorized-ports.html for details

Problem as I mentioned the naming of two optional parameters is not aligned with actual case. image

it should be:

authorizedTCPPorts instead of authorizedTcpPorts authorizedUDPPorts instead of authorizedUdpPorts

jongogogo commented 4 years ago

I can confirm you that it is not the code of the managed rule. I understand that there is the disparity with the managed rule, but they are not related.