search

awslabs / aws-config-rules

[Node, Python, Java] Repository of sample Custom Rules for AWS Config.
http://aws.amazon.com/config/
Creative Commons Zero v1.0 Universal
1.6k stars 854 forks source link

Add Github Actions build #327

Closed gliptak closed 4 years ago

gliptak commented 4 years ago

Signed-off-by: Gábor Lipták gliptak@gmail.com

I confirm these files are made available under CC0 1.0 Universal (https://creativecommons.org/publicdomain/zero/1.0/legalcode)

https://github.com/gliptak/aws-config-rules/actions/runs/87935826

good-bot commented 4 years ago

Module SQS_TRANSIT_ENCRYPTION_CHECK_test SQS_TRANSIT_ENCRYPTION_CHECK/SQS_TRANSIT_ENCRYPTION_CHECK_test.py:19:0: W0611: Unused ClientError imported from botocore.exceptions (unused-import) Module SQS_ENCRYPTION_CHECK_test SQS_ENCRYPTION_CHECK/SQS_ENCRYPTION_CHECK_test.py:53:94: C0326: Exactly one space required after comma sqs_encrypted_queue = {"Attributes":{"QueueArn": "arn:aws:sqs:us-east-1:012345678910:test","KmsMasterKeyId": "alias/aws/sqs","KmsDataKeyReusePeriodSeconds": "300"}} ^ (bad-whitespace) SQS_ENCRYPTION_CHECK/SQS_ENCRYPTION_CHECK_test.py:53:128: C0326: Exactly one space required after comma sqs_encrypted_queue = {"Attributes":{"QueueArn": "arn:aws:sqs:us-east-1:012345678910:test","KmsMasterKeyId": "alias/aws/sqs","KmsDataKeyReusePeriodSeconds": "300"}} ^ (bad-whitespace) SQS_ENCRYPTION_CHECK/SQS_ENCRYPTION_CHECK_test.py:19:0: W0611: Unused ClientError imported from botocore.exceptions (unused-import) ***** Module REST_API_GW_CUSTOMDOMAIN_CHECK_test REST_API_GW_CUSTOMDOMAIN_CHECK/REST_API_GW_CUSTOMDOMAIN_CHECK_test.py:19:0: W0611: Unused ClientError imported from botocore.exceptions (unused-import)

Your code has been rated at 10.00/10

good-bot commented 4 years ago

Module SQS_TRANSIT_ENCRYPTION_CHECK_test SQS_TRANSIT_ENCRYPTION_CHECK/SQS_TRANSIT_ENCRYPTION_CHECK_test.py:19:0: W0611: Unused ClientError imported from botocore.exceptions (unused-import) Module SQS_ENCRYPTION_CHECK_test SQS_ENCRYPTION_CHECK/SQS_ENCRYPTION_CHECK_test.py:19:0: W0611: Unused ClientError imported from botocore.exceptions (unused-import) ***** Module REST_API_GW_CUSTOMDOMAIN_CHECK_test REST_API_GW_CUSTOMDOMAIN_CHECK/REST_API_GW_CUSTOMDOMAIN_CHECK_test.py:19:0: W0611: Unused ClientError imported from botocore.exceptions (unused-import)

Your code has been rated at 10.00/10

gliptak commented 4 years ago

@jongogogo please review

Te imports from above are required for the tests to run

I'm not sure why the CodeBuild linting failed (as I get a login window when clicking on the link)