search

awslabs / aws-crt-cpp

C++ wrapper around the aws-c-* libraries. Provides Cross-Platform Transport Protocols and SSL/TLS implementations for C++.
Apache License 2.0
73 stars 64 forks source link

Build fails with reference to AWS_MQTT5_COTABT_MANUAL #607

Closed nabelekt closed 4 months ago

nabelekt commented 4 months ago

Describe the bug

Build fails with

In file included from /root/gateway/libraries/third_party/aws-crt-cpp/include/aws/crt/Api.h:9,
                 from /root/gateway/libraries/third_party/aws-crt-cpp/source/ImdsClient.cpp:8:
/root/gateway/libraries/third_party/aws-crt-cpp/include/aws/crt/mqtt/Mqtt5Client.h:56:26: error: ‘AWS_MQTT5_COTABT_MANUAL’ was not declared in this scope; did you mean ‘AWS_MQTT5_COTABT_LRU’?
   56 |                 Manual = AWS_MQTT5_COTABT_MANUAL,
      |                          ^~~~~~~~~~~~~~~~~~~~~~~
      |                          AWS_MQTT5_COTABT_LRU

Expected Behavior

Build not failing

Current Behavior

Build fails

Reproduction Steps

Build including Mqtt5Client

Possible Solution

I am guessing AWS_MQTT5_COTABT_MANUAL should be AWS_MQTT5_COTABT_USER

Additional Information/Context

No response

aws-crt-cpp version used

0.26.4

Compiler and version used

gcc version 13.2.0 (Ubuntu 13.2.0-4ubuntu3)

Operating System and version

Ubuntu 23.10

nabelekt commented 4 months ago

It looks like this issue was introduced between v0.24.7 and v0.24.8

bretambrose commented 4 months ago

Your submodules are out of date with the CRT. If you update them, this should go away.

nabelekt commented 4 months ago

Indeed! Apologies for the oversight.