search

awslabs / aws-crt-nodejs

NodeJS bindings for the AWS Common Runtime.
Apache License 2.0
40 stars 27 forks source link

gcc 12 support #323

Closed mikelpr closed 1 year ago

mikelpr commented 2 years ago

seems like compiling with GCC 12 is broken

failing compilation can be reproduced with a fedora:36 docker image (has gcc 12.1.1) successful compilation can be reproduced with the fedora:34 image (has gcc 11.3.1) (run dnf install gcc g++ cmake git npm to have the necessary userspace)

logs: https://gist.github.com/mikelpr/6fe2c6fe378dc28248578a6fe5ae645d

bretambrose commented 2 years ago

Looks like the issues (at least so far) are all in aws-lc I would open up an issue with them.

mikelpr commented 2 years ago

https://github.com/awslabs/aws-lc/issues/487#issuecomment-1142140839 suggests it was fixed in https://github.com/awslabs/aws-lc/commit/038628d24feab1c4fce75c9b6a47bfa99b7c5edc

bretambrose commented 2 years ago

Checking if 1.1.0 has the PR: https://github.com/awslabs/aws-lc/pull/495 Unsure if we can take that version yet even if it does.

bretambrose commented 1 year ago

Not sure when the submodule update to >= 1.1.0 was done, but this issue looks to have been addressed.