Closed trivikr closed 2 years ago
Unfortunately, currently we cannot remove cmake-js
due to it being a build dependency when we need to build from source in a production NPM install. However, we did find a way to remove tar
as a dependency.
Thank you for making this PR! While we cannot use it directly, it has been helpful 🙂 Closing in favor of https://github.com/awslabs/aws-crt-nodejs/pull/338
Issue #, if available: Refs: https://github.com/awslabs/aws-crt-nodejs/issues/333
Description of changes: Moves cmake-js and tar to devDeps
Testing:
The artifact for
aws-crt
is created by runningnpm pack
in the workspace.Before:
After:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.