search

awslabs / aws-crt-nodejs

NodeJS bindings for the AWS Common Runtime.
Apache License 2.0
40 stars 27 forks source link

MQTT311 extra connection callbacks #408

Closed TwistedTwigleg closed 1 year ago

TwistedTwigleg commented 1 year ago

Description of changes:

Adds additional connection callbacks to MQTT311. Specifically, adds onConnectionSuccess, onConnectionFailure, and onConnectionClosed. These callbacks mirror those in V1 and were added to both NodeJS (desktop) and the browser..

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

TwistedTwigleg commented 1 year ago

This PR now also removes the unacked operation statistics checks because they are really flaky in CI due to being heavily dependent on the socket speed of the container. We can add them back later if we find a good way to test them.

TwistedTwigleg commented 1 year ago

Thanks! Merging into main...