search

awslabs / aws-crt-nodejs

NodeJS bindings for the AWS Common Runtime.
Apache License 2.0
38 stars 24 forks source link

Experimental: Babel pre-process step #421

Closed bretambrose closed 11 months ago

bretambrose commented 1 year ago

cmake-js is an irreplacable dependency of the CRT. Starting with major version 7.x, cmake-js uses language features only found in node14+. In order to continue to be able to upgrade cmake-js without having to modify our node baseline to 14, this PR adds a babel-driven pre-processing step that rewrites the options-chaining code in cmake-js to be usable from earlier versions of node.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

graebm commented 11 months ago

Closing this. We're upgrading to Node 14 soon to avoid hacky workarounds