Event stream cleanup assist

awslabs / aws-crt-nodejs

NodeJS bindings for the AWS Common Runtime.

Apache License 2.0

40 stars 27 forks source link

Event stream cleanup assist #424

Closed bretambrose closed 1 year ago

bretambrose commented 1 year ago

Experimental PR to help mitigate potential leaks from not following the eventstream API contract.

Adds automatic close() invocations to eventstream connection and stream when native notifies of disconnect/termination.
Adds automatic terminate stream message when closing an open stream.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bretambrose commented 1 year ago

On second thought, this isn't the right place to do auto-cleanup. Event ordering issues make the RPC client a much better choice where multiple promises can be unioned before invoking close.