search

awslabs / aws-crt-nodejs

NodeJS bindings for the AWS Common Runtime.
Apache License 2.0
40 stars 27 forks source link

Add shim needed for Angular support #440

Closed TwistedTwigleg closed 1 year ago

TwistedTwigleg commented 1 year ago

Description of changes:

With the addition of React support in #428, Angular almost works, but without a shim for globals, Angular doesn't work out of the box. This PR adds the shim to the polyfills so Angular works.

I tested the existing PubSub sample, the React sample in the react_support branch, and the Angular sample in the angular_support branch, and confirmed that in all cases the samples worked as expected. This change to add the shim needed for Angular shouldn't cause any changes to existing customers on any of the browser platforms.

To test the Angular support, see the Angular sample in angular_support.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

TwistedTwigleg commented 1 year ago

Thanks! Merging into main...