Conditionally uri encode custom auth signature values

awslabs / aws-crt-nodejs

NodeJS bindings for the AWS Common Runtime.

Apache License 2.0

37 stars 24 forks source link

Conditionally uri encode custom auth signature values #513

Closed bretambrose closed 7 months ago

bretambrose commented 7 months ago

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bretambrose commented 7 months ago

The PR looks good to me. However, would it be better to have the encoding validation in aws-c-mqtt instead of on binding layer? as we had this issue from other language as well.

How/why would aws-c-mqtt know how to parse the username field?

It's true that we need to do this in every CRT or SDK. But the native client knows nothing about iot core details and shouldn't know anything them.