search

awslabs / aws-crt-nodejs

NodeJS bindings for the AWS Common Runtime.
Apache License 2.0
37 stars 24 forks source link

Service Work Sample #544

Open xiazhvera opened 2 months ago

xiazhvera commented 2 months ago

Issue #, if available:

Description of changes: The sample demo the fix for polyfills: https://github.com/awslabs/aws-crt-nodejs/pull/506

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bretambrose commented 2 months ago

Any way we can get CI for this case?

xiazhvera commented 1 month ago

Any way we can get CI for this case?

We can potentially setup a service worker sample and have it run in CI. However, I'm hesitated about having a service worker sample live in our main repo, as we haven't officially declared support for service workers. Including the sample might lead to misunderstandings among users. Instead, I would prefer making the sample available as a reference rather than an official example. This way, we can provide guidance. Let me know what you think.