search

awslabs / aws-crt-php

Apache License 2.0
322 stars 13 forks source link

Implemented async callbacks to PHP regardless of thread model, Sigv4 signing #24

Closed justinboswell closed 3 years ago

justinboswell commented 3 years ago

Depends on:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

SamRemis commented 3 years ago

Please add a method to expose the following line: if (!extension_loaded('awscrt')) {}

This will reduce code duplication and enable us to throw an error when the extension isn't loaded and a feature requires sigv4a

justinboswell commented 3 years ago

Please add a method to expose the following line: if (!extension_loaded('awscrt')) {}

This will reduce code duplication and enable us to throw an error when the extension isn't loaded and a feature requires sigv4a

See CRT::isAvailable() and CRT::isLoaded()

justinboswell commented 3 years ago

Hope you don't mind if I just run the whole thing through a PHP linter at some point in the future. Figure it'll be easier that way

I will be overjoyed! Then tell me what it is so I can use it to verify!