search

awslabs / aws-crt-php

Apache License 2.0
332 stars 15 forks source link

Add .gitattributes file to ignore paths when exporting #49

Closed michaeldyrynda closed 1 year ago

michaeldyrynda commented 2 years ago

Create a .gitattributes file, and add paths with the export-ignore flag set, so they're not pulled down as part of a project's dependencies via Composer.

VincentLanglet commented 1 year ago

Hi @TingDaoK, would it be possible to review this PR or to provide another one with gitattributes file ?

It would be great to not install things like the tests folder when require for this library.

Thanks

TingDaoK commented 1 year ago

Hi @TingDaoK, would it be possible to review this PR or to provide another one with gitattributes file ?

It would be great to not install things like the tests folder when require for this library.

Thanks

I already did, it's https://github.com/awslabs/aws-crt-php/pull/89 and released with the new change.

VincentLanglet commented 1 year ago

Thanks, and sorry, seems like I was only at the 1.0.4 version. I'll update.

TingDaoK commented 1 year ago

no worries.

Seems like the new github tags were not picked by packagist. https://packagist.org/packages/aws/aws-crt-php You will need to use the dev-main.

Should it be automatically pulled by packagist? https://laravelpackage.com/15-publishing.html#releasing-a-new-version

TingDaoK commented 1 year ago

Oh, okay. I guess it has not updated since 3/3

This package is auto-updated.

Last update: 2023-03-03 17:24:42 UTC

VincentLanglet commented 1 year ago

This is weird. I dunno why the package is not updated on packagist...