awslabs / aws-crt-php

Apache License 2.0
322 stars 13 forks source link

Cleanup composer package #66

Closed bytestream closed 1 year ago

bytestream commented 1 year ago

Is your feature request related to a problem? Please describe.

This package is a dependency of aws/aws-sdk-php

# composer why aws/aws-crt-php
aws/aws-sdk-php  3.229.2  requires  aws/aws-crt-php (^1.0.2)  

It installs a lot of completely useless files:

+vendor/aws/aws-crt-php/NOTICE
+vendor/aws/aws-crt-php/gen_stub.php
+vendor/aws/aws-crt-php/php.ini
+vendor/aws/aws-crt-php/config.w32
+vendor/aws/aws-crt-php/.clang-format-ignore
+vendor/aws/aws-crt-php/php-win.ini
+vendor/aws/aws-crt-php/prepare_package_xml.sh
+vendor/aws/aws-crt-php/package.xml-template_post
+vendor/aws/aws-crt-php/builder.json
+vendor/aws/aws-crt-php/Makefile.frag
+vendor/aws/aws-crt-php/format-check.sh
+vendor/aws/aws-crt-php/run_tests
+vendor/aws/aws-crt-php/package.xml-template_pre
+vendor/aws/aws-crt-php/.clang-format
+vendor/aws/aws-crt-php/crt/
+vendor/aws/aws-crt-php/crt/aws-crt-ffi/
+vendor/aws/aws-crt-php/ext/
+vendor/aws/aws-crt-php/ext/php_util.c
+vendor/aws/aws-crt-php/ext/awscrt.stub.php
+vendor/aws/aws-crt-php/ext/php_aws_crt.h
+vendor/aws/aws-crt-php/ext/http.c
+vendor/aws/aws-crt-php/ext/credentials.c
+vendor/aws/aws-crt-php/ext/stream.c
+vendor/aws/aws-crt-php/ext/crt.c
+vendor/aws/aws-crt-php/ext/event_loop.c
+vendor/aws/aws-crt-php/ext/awscrt_arginfo.h
+vendor/aws/aws-crt-php/ext/awscrt.c
+vendor/aws/aws-crt-php/ext/crc.c
+vendor/aws/aws-crt-php/ext/signing.c
+vendor/aws/aws-crt-php/ext/logging.c
+vendor/aws/aws-crt-php/run_tests.bat
+vendor/aws/aws-crt-php/Makefile.frag.w32
+vendor/aws/aws-crt-php/prepare_release.sh
+vendor/aws/aws-crt-php/config.m4

Describe the solution you'd like

Exclude unnecessary files from composer archive via .gitattributes - https://php.watch/articles/composer-gitattributes

Describe alternatives you've considered

N/A

Additional context

Relates to https://github.com/awslabs/aws-crt-php/pull/64, https://github.com/awslabs/aws-crt-php/pull/49

TingDaoK commented 1 year ago

related https://github.com/awslabs/aws-crt-php/pull/88

TingDaoK commented 1 year ago

the new release (v1.1.0) has been cut, it should fix the issue.