search

awslabs / aws-crt-python

Python bindings for the AWS Common Runtime
Apache License 2.0
87 stars 42 forks source link

Make it possible to use OpenSSL on Unix #454

Closed nforro closed 1 year ago

nforro commented 1 year ago

This patch makes it possible to set USE_OPENSSL environment variable to build and link the module with OpenSSL rather than AWS-LC on Unix.

Note: aws-c-cal already accepts USE_OPENSSL CMake option, so setting the environment variable affects it as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

graebm commented 1 year ago

Curious, what's the motivation behind this? What problem are you trying to solve?

nforro commented 1 year ago

I'm packaging aws-crt-python for Fedora, and the package needs to comply with Fedora Crypto Policies. That can be conveniently achieved by linking with OpenSSL.

Another option would be to make AWS-LC compliant with the policies, but I don't know how realistic that is.

graebm commented 1 year ago

Cool, yeah, just making sure there's a good motivation before we increase the surface area of things to support.

Talked about it with the team. We want to use a different string, and want to add CI to ensure that it works. We'll get something together ASAP

nforro commented 1 year ago

Talked about it with the team. We want to use a different string, and want to add CI to ensure that it works. We'll get something together ASAP

Great, thanks!

nforro commented 1 year ago

Closing in favor of #456.