awslabs / aws-crt-python

Python bindings for the AWS Common Runtime
Apache License 2.0
87 stars 42 forks source link

Revert "Remove linker hack (#462)". Always link dependencies statically. #469

Closed graebm closed 1 year ago

graebm commented 1 year ago

Issue: "Remove linker hack (#462)" caused internal Amazon devs to start having issues building Lambda applications.

Investigation: In Amazon's internal build system, dependencies are built as both static and shared libs. "Remove linker hack (#462)" resulted in a switch from using static libs, to using the shared libs.

Lambda applications need all their runtime dependencies explicitly packaged up. The switch to use shared libs meant devs needed to add a lot more runtime dependencies.

Description of changes: Put back code that forces dependencies to be linked statically, to keep things simple and minimize runtime dependencies.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.