Issue:
The exceptions delivered from the S3Client were lacking information like the HTTP response code, headers, & body. You could get the extra information from the on_done callback, but it would be nice to get it from the exception, so you could use the request.finished_future instead of the on_done callback if you wanted.
Description of changes:
Add new error type: awscrt.s3.S3ResponseError, which inherits from awscrt.exceptions.AwsCrtError. If we have information about the failed request, then use an S3ResponseError instead.
Debatable:
Should this live in awscrt.exceptions or awscrt.s3?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue: The exceptions delivered from the S3Client were lacking information like the HTTP response code, headers, & body. You could get the extra information from the
on_donecallback, but it would be nice to get it from the exception, so you could use therequest.finished_futureinstead of theon_donecallback if you wanted.Description of changes: Add new error type:
awscrt.s3.S3ResponseError, which inherits fromawscrt.exceptions.AwsCrtError. If we have information about the failed request, then use anS3ResponseErrorinstead.Debatable:
awscrt.exceptionsorawscrt.s3?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.