Issue:
The latest AWS-LC was crashing on OpenBSD 7.4, when running test test.test_http_client.TestClient.test_connect_pq_tlsv1_0_2021_05
Investigation:
AWS-LC added OpenBSD 7.4 and 7.5 Support in v1.26.0. Ironically, these changes broke our existing OpenBSD 7.4 CI. My understanding is: "support OpenBSD" means "support fancy assembly math, instead of using vanilla C code math" on OpenBSD. This fancy assembly math currently reads from the .text section of the library, which is forbidden if a library is linked with the --execute-only flag, which OpenBSD 7.4+ uses by default.
Description of changes:
Update to AWS-LC v1.24.0 -> v1.28.0
Set '-Wl,--no-execute-only' flag when building for OpenBSD and using AWS-LC
Add OpenBSD 7.4 and 7.5 to CI (OpenBSD supports its two most recent releases)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue: The latest AWS-LC was crashing on OpenBSD 7.4, when running test
test.test_http_client.TestClient.test_connect_pq_tlsv1_0_2021_05Investigation: AWS-LC added OpenBSD 7.4 and 7.5 Support in v1.26.0. Ironically, these changes broke our existing OpenBSD 7.4 CI. My understanding is: "support OpenBSD" means "support fancy assembly math, instead of using vanilla C code math" on OpenBSD. This fancy assembly math currently reads from the .text section of the library, which is forbidden if a library is linked with the
--execute-onlyflag, which OpenBSD 7.4+ uses by default.Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.