search

awslabs / aws-crt-swift

Apache License 2.0
15 stars 19 forks source link

STSWebIdentity Resolver Bug #279

Closed sichanyoo closed 2 months ago

sichanyoo commented 2 months ago

Describe the bug

Upstream ticket: https://github.com/awslabs/aws-sdk-swift/issues/1694

Expected Behavior

Refer to upstream ticket

Current Behavior

Refer to upstream ticket

Reproduction Steps

Refer to upstream ticket

Possible Solution

No response

Additional Information/Context

No response

aws-crt-swift version used

0.33.0

Compiler and Version used

Xcode 15.4

Operating System and version

Sonoma 14.6.1

sichanyoo commented 2 months ago

The bug turned out to be due to the provided role session name not following the regex outlined in the docs here. The role session name that was used with this sample project had a white space in it.

After discussion with @waahm7, as CRT does no validation of input parameters and C does not have regex parser, we decided it would be best if we add this input parameter check to SDK wrapper.

Closing this ticket (and the one in downstream CRT repo) as it is not an issue with the SDK / CRT. I'll be creating a follow-up ticket upstream to this for adding role session name param check in our resolve wrappers.

github-actions[bot] commented 2 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.