search

awslabs / aws-device-farm-gradle-plugin

Gradle plugin for AWS Device Farm.
Apache License 2.0
61 stars 32 forks source link

Add support for Polling and exporting ADF Run Results to JUnit XML #22

Closed andreas-marschke closed 6 years ago

andreas-marschke commented 6 years ago

Hi everyone!

As was a requirement stated by several throughout time on this project, it would be great to have the plugin wait for an ADF Run to finish. (#15, #11 )

This MR adds support for that and the ability to export the results to JUnit XML.

Additionally it fixes a bug with running ADF Tests on Android Libraries which previously failed to upload due to a nullpointer exception in the plugin code. (#14)

I did not bump the version number yet as I'd like to receive feedback on the MR first.

@appwiz Please Review

andreas-marschke commented 6 years ago

@michael-b-willingham @bradley-curran @r7o Any of you able to take this and get it merged? Don't want this to linger around too long.

andreas-marschke commented 6 years ago

@ahawker Updated/Reset the MR'ed code. Hope this works for you now. Closer to the master documentation and added docs/changes as requested. Let me know what you think.

andreas-marschke commented 6 years ago

@erickentry added 19451c33bf4a98285b88f62141450c275261e181 resolving your problem.

bradley-curran commented 6 years ago

Hi @andreas-marschke, thanks for contributing!

We want to introduce these features into the main code base as soon as possible. To do this would you be able to break this current PR into two separate feature PRs?

That way we can do a numbered release per feature introduced into master.

One should be for adding support for polling and the other should be exporting the run results to JUnit XML.

andreas-marschke commented 6 years ago

@bradley-curran Sounds plausible. Will do. Closing this PR then.