search

awslabs / aws-device-farm-jenkins-plugin

Jenkins plugin for AWS Device Farm.
Apache License 2.0
89 stars 66 forks source link

Add path and archive options to saving results locally #137

Closed kevin-brotcke closed 4 weeks ago

kevin-brotcke commented 12 months ago

There are two different uses cases we have that the existing options didn't cover:

  1. We run multiple Device Farm jobs in a single build and enabling saving results locally overrides the previous run files.

    We've added a new option "Results path" which lets us set a unique path per run so we no longer have conflicts.

  2. The results are saved directly to the artifacts directory. That means we can't run our post-processing actions on them without unarchiving then re-archiving them. We also can't save only part of the results.

    We've added a second new boolean option "Archive results" that when unchecked will save results directly to the workspace folder instead. Then when we are ready we can archive all or part of them later in the build.

We've forked the plugin and have been running this change in production without issues for a few months now. Users should not see any behavior changes with the upgrade since the default options match current values.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nikhil-dabhade commented 10 months ago

Ack for this request. I will pick this up on Nov 9th for review.

nikhil-dabhade commented 7 months ago

Validating the PR now.

kevin-brotcke commented 1 month ago

Looks like my code has been merged as part of this commit https://github.com/awslabs/aws-device-farm-jenkins-plugin/commit/d887bf63631909f62e94e05c555d547b6fc323e5

kevin-brotcke commented 4 weeks ago

Closing since I've verified my pull-request code has been merged as a combined commit linked above.