awslabs / aws-device-farm-jenkins-plugin

Jenkins plugin for AWS Device Farm.
Apache License 2.0
89 stars 66 forks source link

modified code to check for enviroment variables on filters #88

Closed jamesknowsbest closed 5 years ago

jamesknowsbest commented 5 years ago

Issue:

Currently, the Jenkins plugin for Device Farm does not accept environment variable for filter values. This change allows this and also accepts default string values.

Tested here environment var: https://us-west-2.console.aws.amazon.com/devicefarm/home#/projects/8122b260-5eec-43e5-ae03-a0bf1c5f2ff7/runs/9ad7844f-647f-4880-9d2f-3589176ce448

Normal string values: https://us-west-2.console.aws.amazon.com/devicefarm/home#/projects/8122b260-5eec-43e5-ae03-a0bf1c5f2ff7/runs/140ab823-56e2-4eac-bab8-a09da705001b

WARNING: I have only tested this with XCUI tests however I thought the changes could be applicable to the other frameworks as well. I did not test those.