Closed stefanverhoeff closed 5 years ago
This problem has been affecting me too, and the fix seems very straightforward.
Is there anything holding this?
Yep maybe @nikhil-dabhade or @anurag1408 can help getting this merged? ;-)
@stefanverhoeff @paulo-raca We are testing this right now. Shooting to have this merged and released before end of next week.
And first and foremost, thank you for the contribution :)
@stefanverhoeff @paulo-raca We are testing this right now. Shooting to have this merged and released before end of next week.
Great! Please have a look at PR #90 and #91 too ;-)
@stefanverhoeff We merged #91 . Merging this request now. Again, thank you for your contributions.
Thanks for the follow-ups @nikhil-dabhade and @piyushag-aws :-)
The process of copying the remote test results files to Jenkins for archiving leaves a file stream open. This causes a build-up of open file descriptors on the Jenkins Master which will eventually crash a unix system depending on ulimit 'open files' setting.
This fix replaces the inline copying of files with the build-in FilePath.copyFrom() method which closes the streams correctly.
This patch is running in our Production Jenkins currently and solved our issue with build-up of open files.
To illustrate, previous we saw output like this on the Jenkins Master:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.