search

awslabs / aws-elasticache-cluster-client-libmemcached

Libmemcached library support for Amazon ElastiCache Memcached Cluster for PHP. The client is available at https://github.com/awslabs/aws-elasticache-cluster-client-memcached-for-php.
Other
26 stars 24 forks source link

Fix build failure and automake support #11

Open jdolinski opened 7 years ago

jdolinski commented 7 years ago

9 #8 #7

@kmaleyev I created a new pull request to more clearly define the changes and incorporate your feedback. I have tested the build on Ubuntu 14 and Amazon Linux 2017.03

I organized this PR more cleanly and discarded some changes after your clarification and feedback. I tried squashing PR #10 but it got really ugly and wanted to be clear on the changes.

Let me know your thoughts, thanks in advance.

jdolinski commented 7 years ago

Hi Kosty, Sorry about submitting a second pull request but I had problems squashing. Once I received your feedback, I realized I had made some assumptions that were not true and needed to back some things out. Look forward to your feedback and thoughts.

raphaelquati commented 7 years ago

I'm trying to use your PR, to create a docker image to run in ECR. I'm using PHP-7.1.5 image (debian:jessie).

apt install automake autoconf libtool git shtool autogen
git clone ......
cd .....
rm -rf .git
autoreconf -vfi
mkdir BUILD
cd BUILD
../configure --prefix=$(pwd)/local --with-pic

The configure gives error: 

checking for cc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
configure: error: cannot find install-sh, install.sh, or shtool in ".." "../.." "../../.."

Checking the build-aux dir (created by autoreconf):

root@0546d5a47108:/tmp/aws-elasticache-cluster-client-libmemcached/build-aux# ls -l
total 424
-rwxr-xr-x 1 root root   7333 Jun 22 19:36 compile
-rwxr-xr-x 1 root root  42856 Jun 22 19:36 config.guess
-rwxr-xr-x 1 root root  35837 Jun 22 19:36 config.sub
-rwxr-xr-x 1 root root  23566 Jun 22 19:36 depcomp
-rwxr-xr-x 1 root root  14431 Jun 22 19:36 install-sh
-rw-r--r-- 1 root root 283672 Jun 22 19:36 ltmain.sh
-rwxr-xr-x 1 root root   6872 Jun 22 19:36 missing
-rwxr-xr-x 1 root root   4287 Jun 22 19:37 test-driver
allyraza commented 7 years ago

@raphaelquati you can symlink shtool into the dir you extracted the tar configure: error: cannot find install-sh, install.sh, or shtool in ".." "../.." "../../.."