search

awslabs / aws-elasticache-cluster-client-memcached-for-java

Amazon ElastiCache Cluster Client for Java - enhanced library to connect to ElastiCache clusters.
http://docs.amazonwebservices.com/AmazonElastiCache/latest/UserGuide/AutoDiscovery.html
Apache License 2.0
87 stars 54 forks source link

Fixing issue where an NPE would occur if a authDescriptor was sent in… #5

Closed eagletalon139 closed 1 year ago

eagletalon139 commented 8 years ago

…to the memcached instance, found while trying to implement SASL for customers to have a way to secure their memcached instances.

eagletalon139 commented 8 years ago

When the addObserver was getting called it was trying to grab the, supposed to be already created connection, but returned with an NPE. Moved the code around and made sure this worked locally, however do not know enough about the ant build process to get the tests I created locally to run. So If anyone can add tests or point me in the right direction of adding tests that would be amazing.

eagletalon139 commented 7 years ago

Would like to see some comments or thoughts on this PR. Even if it does not go anywhere would love some feedback.

eagletalon139 commented 5 years ago

@QuChen88 - Do you have time to review or are you still someone that would have merging capabilities in this library? This is a small change to help setup better security around memcached servers.

redinger commented 3 years ago

+1

Bumping this old pull request. I just ran into this issue when trying to use an authenticated connection and confirmed that the patch fixes it.

FixingBugs commented 1 year ago

+1

Bumping again as this is helpful for implementing secure memcached connections with AWS infrastructure.

QuChen88 commented 1 year ago

I merged this PR. However, please note that SASL authentication is no longer recommended as it relies on binary protocol which is on the deprecation path for memcached. A better approach to authentication appears to be TLS based auth. For more details please see https://github.com/memcached/memcached/issues/847

tristantarrant commented 1 year ago

would it be possible to have a 1.2.1 release with this fix ?