awslabs / aws-elasticache-cluster-client-memcached-for-php

Amazon ElastiCache Cluster Client is an enhanced PHP library to connect to ElastiCache clusters. This client library has been built upon libmemcached and is released under the Apache License.
Other
62 stars 33 forks source link

Replace obsolete AC_TRY_FOO with AC_FOO_IFELSE #22

Closed petk closed 6 years ago

petk commented 6 years ago

Hello,

Autoconf made several macros obsolete including the AC_TRY_COMPILE and AC_TRY_LINK in 2000 and since Autoconf 2.50: http://git.savannah.gnu.org/cgit/autoconf.git/tree/ChangeLog.2

These macros should be replaced with the current AC_FOO_IFELSE instead.

It is fairly safe to upgrade and take the recommendation advice of autoconf upgrade manual since the upgrade should be compatible at least with PHP versions 5.4 and up, on some systems even with PHP 5.3. PHP versions from 5.4 to 7.1 require Autoconf 2.59+ and PHP 7.2+ require Autoconf 2.64+.

This patch was created with the help of autoupdate script.

Reference docs:

Thanks.

sodabrew commented 6 years ago

Hold up. This repo is based off the the upstream open source project php-memcached. I advise submitting the changes there.

petk commented 6 years ago

Of course, I've sent these to the php-memcached as well...

petk commented 6 years ago

Bump....