Closed n10000k closed 5 years ago
Given the still outstanding lack of support for 7.2 I wouldn't hold my breath.
Given the still outstanding lack of support for 7.2 I wouldn't hold my breath.
One could only hope. Looks like Redis is the only option as AWS don't want to keep this repo up to date.
One can easily conclude that this project is dead considering the time of the last commit. I switched to Redis long time ago.
I did the same today, switched to ubuntu 18.04, php7.2 and redis.
Bump up ✋ Do you have any updates about development for PHP 7.3 support?
I opened an aws support case asking about this - while (as always) they didn't commit to anything, hopefully it bumped up the priority on whoever's responsible for this over there nowadays 🤷♂
@comalle23 Did AWS get back to your support ticket?
@comalle23 Did AWS get back to your support ticket? they did before i posted - said they couldn't commit yada yada but they'd maybe ping whoever is responsible for it and maybe they'd do something about it someday, etc. still haven't last time i checked. 🤷♂
So I've managed to build this on CentOS 7 for PHP 7.3 using 7.1 instructions from here (thanks @pabdavis & @jpriebe ) : https://github.com/awslabs/aws-elasticache-cluster-client-memcached-for-php/issues/11#issuecomment-301193228
This used lib-memcached 1.0.8 as many mention lots of building errors with latest.
Changing the instructions above to use remi-php73 and then modifying 2 files before running final make
command:
/tmp/aws-elasticache-cluster-client-memcached-for-php/php_memcached.c (Line 1278)
Change GC_REFCOUNT(&le) = 1;
to GC_SET_REFCOUNT(&le, 1);
and Line 3651
Change GC_REFCOUNT(fci.object)++;
to GC_ADDREF(fci.object);
/tmp/aws-elasticache-cluster-client-memcached-for-php/php_memcached_session.c (Line 379)
Change GC_REFCOUNT(&le) = 1;
to GC_SET_REFCOUNT(&le, 1);
The above changes reflect changes in the Zend API.
For the lazy people: http://www.filedropper.com/amazon-elasticache-cluster-clientphp73
@theoc31 Thank you for your tip! Also, be aware if you are using DISTRIBUTION_CONSISTENT option, it has different behavior with lib-memcached 1.0.8. This option not backward compatible with legacy lib-memcached 1.0.8 and lib-memcached 1.0.18. For more information: https://github.com/awslabs/aws-elasticache-cluster-client-memcached-for-php/issues/28
@theoc31 Thank you for your tip! Also, be aware if you are using DISTRIBUTION_CONSISTENT option, it has different behavior with lib-memcached 1.0.8. This option not backward compatible with legacy lib-memcached 1.0.8 and lib-memcached 1.0.18. For more information: #28
Thanks for that @antydemant. I've now successfully also recompiled the client with lib-memcached 1.0.18. Not sure why it initially failed but got it working on a clean box. That should hopefully allow people like me to move to php 7.3 with elasticache. 😄
Here it is for anyone who needs it: https://mega.nz/#!niwSkCxT!YcPNcaMhfn8gLDIdCCeux4GNbH2LlSyjxDmzaimw5LQ
Here's a patched fork for php-7.3 support https://github.com/liip-forks/aws-elasticache-cluster-client-memcached-for-php It just applied the 3 lines mentioned at https://github.com/awslabs/aws-elasticache-cluster-client-memcached-for-php/issues/27#issuecomment-517274378
Maybe it helps someone
I'm an upstream maintainer at https://github.com/php-memcached-dev/php-memcached. As I mentioned in #29, I really want to see the AWS folks sync with upstream. It's a positive multiplier effect because it means everyone bumps into the same gotcha & bugs and can get them fixed for everyone over time.
I don't have any personal contacts with the AWS folks who would be working on this, however. Thanks for posting/sharing your efforts!
Merged the upstream from https://github.com/php-memcached-dev/php-memcached. php-7.3 is now supported.
Hey,
When will 7.3 be supported?
My dockerfile:
Errors on docker build:
Any guidance on a fix would be appreciated, thanks in advance.